Top Left Text cha

Website Development Services

The list of bugs for JS Jobs was getting way too long so I'll just start adding them as separate articles.

JS Jobs Missing Cities

There are tons of missing cities.  Not surprising given the 100s of bugs in this component.  I tried resolving this by adding the city manually to the database.  That does not work.  I believe it's because of a sloppiness... naming a column 'serverid', which has no indication whatsoever what it's used for (like much of the classes, ids, etc. in what I've deemed the worst extension ever made available in the JED).

Okay... I found the exact issue.  It's, once again, poor coding decisions.  They have the query where you select the city from the auto-completed list to only display up to 15 cities.  That's just plain ignorant.  There are like 30 cities in the U.S. named Auburn.  So, if you wanted to select Auburn, WA, it's impossible because it would only show 15 (no matter how you spelled it, if you added the state, etc.).  The fix was to change the following line...

if (isset($countryname)) { $query .= " WHERE city.cityName LIKE " . $db->quote($cityname . '%') . " AND country.name LIKE " . $db->quote($countryname . '%') . " AND country.enabled = 1 AND city.enabled = 1 LIMIT " . $this->getJSModel('configurations')->getConfigValue("number_of_cities_for_autocomplete"); } else { $query .= " WHERE city.cityName LIKE " . $db->quote($cityname . '%') . " AND country.enabled = 1 AND city.enabled = 1 LIMIT " . $this->getJSModel('configurations')->getConfigValue("number_of_cities_for_autocomplete"); }​


With the following (basically removing the call to get the number of the limit (where ever that comes from) and replace with '50'...

if (isset($countryname)) { $query .= " WHERE city.cityName LIKE " . $db->quote($cityname . '%') . " AND country.name LIKE " . $db->quote($countryname . '%') . " AND country.enabled = 1 AND city.enabled = 1 LIMIT 50"; } else { $query .= " WHERE city.cityName LIKE " . $db->quote($cityname . '%') . " AND country.enabled = 1 AND city.enabled = 1 LIMIT 50"; }​



By the way, I requested this component be removed from the Joomla directory so it wouldn't make Joomla look so bad.  My request was denied.  That tells me that the Joomla Extensions Directory [and the Joomla Community itself at Joomla.org] does not give a damn whether Joomla looks bad or not.  They don't care if it fails in the end because of these horrible horrible extensions that they let pass.  I bet they would let you install a virus if it increased the number of extensions available by one.
  • No comments found

Leave your comments

Post comment as a guest

0
Your comments are subjected to administrator's moderation.
X